Skip to content

feat: add every, includes, unaryAccumulate, and unaryReduceSubarray to namespace #6605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgryte merged 2 commits into from
Apr 9, 2025
Merged

feat: add every, includes, unaryAccumulate, and unaryReduceSubarray to namespace #6605

kgryte merged 2 commits into from
Apr 9, 2025

Conversation

@PraveshKunwar
Copy link
Contributor

@PraveshKunwar PraveshKunwar commented Apr 8, 2025 •
edited
Loading

Resolves #6574 .
Resolves #6589 .

Description

What is the purpose of this pull request?

This pull request:

  • Removes whitespaces found in github/subscriptions/README.md and datasets/nightingales-rose/README.md (6574). Additionally, fixes warnings in @stdlib/ndarray/base/lib/index.js (6589)

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

PraveshKunwar and others added 2 commits April 7, 2025 21:47
@PraveshKunwar
fix: fixed issues 6574 and 6589
5902973 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@PraveshKunwar
fix: removed whitespace in subscriptions
a3ffe3a 
Signed-off-by: Pravesh Kunwar <[email protected]>
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Apr 8, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 8, 2025

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot
stdlib-bot reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@PraveshKunwar PraveshKunwar changed the title Praveshk/ndarray warning fix: removed whitespace and resolve warning issues found in ndarray Apr 8, 2025
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 8, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 9, 2025
@kgryte kgryte changed the title fix: removed whitespace and resolve warning issues found in ndarray feat: add every, includes, unaryAccumulate, and unaryReduceSubarray to namespace Apr 9, 2025
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 9, 2025
@kgryte
Copy link
Member

kgryte commented Apr 9, 2025

As the CI failures are not attributable to changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte merged commit a468fa8 into stdlib-js:develop Apr 9, 2025
100 of 107 checks passed
@sahil20021008 sahil20021008 mentioned this pull request Apr 14, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors Fix EditorConfig lint errors

3 participants

@PraveshKunwar @stdlib-bot @kgryte